clarify the required accuracy for OpFMod and OpFRem #871
+32
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alycm
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
LGTM.
On the call on 2023-01-17 there was a concern if this wording would cause a problem for implementations that are more precise. The table is explicitly "minimum accuracy" though, so I think it's fine.
There was also mention of a concern that the SPIR-V LLVM translator could be less precise than this, but not sure what to say about it here. I'll add a comment to the original issue.
bashbaug
force-pushed
the
clarify-opfmod-opfrem
branch
from
ed97470
to
82499ce
Compare
|
I've converted this to a draft while we determine whether there is a precision issue or not. |
|
Feedback from discussion on April 11th: it would be best to have a test for the desired behavior first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #859
Clarifies that the required accuracy for OpFMod and OpFRem is derived from floor and trunc. This is the same behavior as Vulkan - see link.